linux-kernel - Re: perf, x86: Provide a PEBS capable cycle event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTintgqOkwo=WRH_9vGwGgXf0XrfU2e++daUOOG=i@mail.gmail.com>
Date:	Wed, 26 Jan 2011 13:00:56 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: perf, x86: Provide a PEBS capable cycle event

On Wed, Jan 26, 2011 at 12:37 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:
>
>> Gitweb:     http://git.kernel.org/linus/7639dae0ca11038286bbbcda05f2bef601c1eb8d
>> Commit:     7639dae0ca11038286bbbcda05f2bef601c1eb8d
>> Parent:     abe43400579d5de0078c2d3a760e6598e183f871
>> Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
>> AuthorDate: Tue Dec 14 21:26:40 2010 +0100
>> Committer:  Ingo Molnar <mingo@...e.hu>
>> CommitDate: Thu Dec 16 11:36:44 2010 +0100
>>
>>     perf, x86: Provide a PEBS capable cycle event
>>
>>     Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>>     LKML-Reference: <new-submission>
>>     Signed-off-by: Ingo Molnar <mingo@...e.hu>
>> ---
>>  arch/x86/kernel/cpu/perf_event_intel.c |   26 ++++++++++++++++++++++++++
>>  1 files changed, 26 insertions(+), 0 deletions(-)
>
> btw., precise profiling via PEBS:
>
>  perf record -e cycles:p ...
>
> works pretty nicely now on Nehalem CPUs and later.
>
The problem is that cycles:p is not equivalent to cycles in terms of how
cycles are counted. cycles counts only unhalted cycles. cycles:p counts
ALL cycles, event when the CPU is in halted state.

Thus, in per-thread mode, I believe you, it works.

In system-wide, it all depends on how the kernel is configured w.r.t. to idle
and what your workload does. If you know you're never going idle on any
of the monitored CPUs during the measurement, then you're fine.

Otherwise, you have a distortion. You can get samples from halted CPUs,
likely pointing to the idle routine.

If your system uses idle=poll, then you are okay. Otherwise, the problem
mentioned above applies.


> Could we perhaps make perf record and perf top default to cycles:p on x86, and
> silently fall back to regular cycles events if the CPU does not support this event
> type?
>
> That would make our profiles more precise by default - without users having to do
> anything funky.
>
> Thanks,
>
>        Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/