linux-kernel - Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110126130718.GN2721@bicker>
Date:	Wed, 26 Jan 2011 16:07:18 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Marek Belisko <marek.belisko@...n-nandra.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] staging: ft1000: Fix coding style in
 write_blk_fifo() function.

You didn't introduce it but do you know what the code is trying to do
here?

        byte_length = word_length * 4;

        if (byte_length % 4)
                aligncnt = 4 - (byte_length % 4);
        else
                aligncnt = 0;
        byte_length += aligncnt;

        if (byte_length && ((byte_length % 64) == 0))
                byte_length += 4;

        if (byte_length < 64)
                byte_length = 68;


Apparently the stuff has to be aligned to 4 bytes, but it can't be
aligned at 64 bytes and it can't be less than 68 bytes long.  The 
part that especially confuses me is why it can't be aligned at 64 bytes.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/