linux-kernel - Re: [PATCH] driver-core: remove conditionals around devicetree pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jan 2011 11:17:34 +0800
From:	Greg KH <gregkh@...e.de>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver-core: remove conditionals around devicetree
 pointers

On Tue, Jan 25, 2011 at 07:02:02PM -0700, Grant Likely wrote:
> Having conditional around the of_match_table and the of_node pointers
> turns out to make driver code use ugly #ifdef blocks.  Drop the
> conditionals and remove the #ifdef blocks from the affected drivers.
> 
> Also tidy up minor whitespace issues within the same hunks.
> 
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
> 
> I've held off doing this since I didn't want to needlessly increase
> the size of struct device and struct device_driver for users who don't
> use CONFIG_OF.  However, its quibbling about a tiny amount of memory,
> and #ifdef'ing it out this way is ugly for driver code.
> 
> Alternately, if I should be concerned about the extra memory, I could
> define some macros/inlines similar to how CONFIG_NUMA is handled.

No objection from me, I was wondering when you would get around to doing
this :)

If you want me to take this in my tree, I'd be glad to, otherwise feel
free to send it through yours, and add a:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
to it.

Nice job,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/