linux-kernel - Re: [PATCH UPDATED 21/32] fs/aio: aio_wq isn't used in memory reclaim path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x491v3zzkzz.fsf@segfault.boston.devel.redhat.com>
Date:	Wed, 26 Jan 2011 11:29:36 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Benjamin LaHaise <bcrl@...ck.org>,
	linux-aio@...ck.org
Subject: Re: [PATCH UPDATED 21/32] fs/aio: aio_wq isn't used in memory reclaim path

Tejun Heo <tj@...nel.org> writes:

> aio_wq isn't used during memory reclaim.  Convert to alloc_workqueue()
> without WQ_MEM_RECLAIM.  It's possible to use system_wq but given that
> the number of work items is determined from userland and the work item
> may block, enforcing strict concurrency limit would be a good idea.
>
> Also, move fput_work to system_wq so that aio_wq is used soley to
> throttle the max concurrency of aio work items and fput_work doesn't
> interact with other work items.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Benjamin LaHaise <bcrl@...ck.org>
> Cc: Jeff Moyer <jmoyer@...hat.com>

You actually missed that CC.  ;-)

> Cc: linux-aio@...ck.org
> ---
> Patch description updated to describe fput_work change.  If there's no
> further objection, I'll push it through workqueue#for-2.6.39.  Thanks.

Looks good to me, based on not changing existing semantics.

Acked-by: Jeff Moyer <jmoyer@...hat.com>

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/