linux-kernel - Re: [PATCH] perf: fix alloc_callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110126162309.GB1757@nowhere>
Date:	Wed, 26 Jan 2011 17:23:12 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>, stable@...nel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Miller <davem@...emloft.net>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: fix alloc_callchain_buffers()

On Tue, Jan 25, 2011 at 07:40:51PM +0100, Eric Dumazet wrote:
> Commit 927c7a9e92c4 ( perf: Fix race in callchains ) introduced a
> mismatch in the sizing of struct callchain_cpus_entries.
> 
> nr_cpu_ids must be used instead of num_possible_cpus(), or we might get
> out of bound memory accesses on some machines.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Frederic Weisbecker <fweisbec@...il.com>
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Arnaldo Carvalho de Melo <acme@...hat.com>
> CC: David Miller <davem@...emloft.net>
> CC: Stephane Eranian <eranian@...gle.com>
> CC: stable@...nel.org

Good catch, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/