linux-kernel - Re: [tip:sched/core] sched: Untangle cpu-load and timekeeping code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296072183.15234.12.camel@laptop>
Date:	Wed, 26 Jan 2011 21:03:03 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched: Untangle cpu-load and timekeeping code

On Wed, 2011-01-26 at 20:29 +0800, Yong Zhang wrote:
> On Wed, Jan 26, 2011 at 12:14:43PM +0000, tip-bot for Peter Zijlstra wrote:
> > Commit-ID:  18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> > Gitweb:     http://git.kernel.org/tip/18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> > Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > AuthorDate: Tue, 25 Jan 2011 11:30:35 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Wed, 26 Jan 2011 12:33:23 +0100
> > 
> > sched: Untangle cpu-load and timekeeping code
> > 
> > Remove the calc_global_load() call from the timekeeping code and make
> > it local to the scheduler.
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > LKML-Reference: <new-submission>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > ---
> > +static void calc_global_load(unsigned long __data)
> >  {
> >  	long active;
> >  
> > -	calc_global_nohz(ticks);
> > +	calc_global_nohz();
> >  
> >  	if (time_before(jiffies, calc_load_update + 10))
> >  		return;
> 
> We should not do this checking any more. In normal case,
> it will always return false.
> If it indeed returns true for some reason, we will lose the
> timer forever.

Its needed for the nohz case, arguably we could move it inside
calc_global_nohz().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/