linux-kernel - Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296079382.29801.45.camel@c-dwalke-linux.qualcomm.com>
Date:	Wed, 26 Jan 2011 14:03:02 -0800
From:	Daniel Walker <dwalker@...eaurora.org>
To:	David Brown <davidb@...eaurora.org>
Cc:	Saravana Kannan <skannan@...eaurora.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote:
> On Tue, Jan 25 2011, Daniel Walker wrote:
> 
> > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote:
> >> On 01/25/2011 01:38 PM, Daniel Walker wrote:
> >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to
> >> >> where they are actually used.
> >> >>
> >> >
> >> > I'd do two patches for this. The stuff your doing is too disconnected.
> >> >
> >> > Daniel
> >> >
> >> There is a whole bunch of unused code in the clock files and it's being 
> >> deleted. I don't see a point of splitting it up per file.
> >
> > It's easier to review when changes aren't merged that don't related to
> > each other.
> 
> In this particular case, the patch is a bunch of removal of dead code,
> and kind of makes sense to keep it together.  I'm fine with it as is.

He's adding stuff too .. So it's not _just_ removal which is what I was
getting at.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/