linux-kernel - Re: [tip:sched/core] sched: Untangle cpu-load and timekeeping code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=Dz5Ybk6SEg0efd8fEBa8C-xzj-nyWnxsWsgao@mail.gmail.com>
Date:	Thu, 27 Jan 2011 15:13:11 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched: Untangle cpu-load and timekeeping code

On Wed, Jan 26, 2011 at 8:14 PM, tip-bot for Peter Zijlstra
<a.p.zijlstra@...llo.nl> wrote:
> Commit-ID:  18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> Gitweb:     http://git.kernel.org/tip/18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> AuthorDate: Tue, 25 Jan 2011 11:30:35 +0100
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Wed, 26 Jan 2011 12:33:23 +0100
>
> sched: Untangle cpu-load and timekeeping code
>
> Remove the calc_global_load() call from the timekeeping code and make
> it local to the scheduler.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> LKML-Reference: <new-submission>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Now another question comes into my head:

Previous we stop load calculation only when we goes to full idle,
say every CPU goes to idle. tick_do_timer_cpu is jumping to
the no-idle one so we can always get the real load.

But now, if the CPU on which the global_load_timer resident
goes to idle and there is still no-idle cpu in system, the load
calculation stops. So it's not reflecting the real load after
that.

Thanks,
Yong

-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/