linux-kernel - Re: rwsem: rwsem: Remove redundant asmregparm annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1101271612050.31804@localhost6.localdomain6>
Date:	Thu, 27 Jan 2011 16:12:40 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	David Howells <dhowells@...hat.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Richard Henderson <rth@...ddle.net>,
	Tony Luck <tony.luck@...el.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	David Miller <davem@...emloft.net>,
	Chris Zankel <chris@...kel.net>
Subject: Re: rwsem: rwsem: Remove redundant asmregparm annotation

On Thu, 27 Jan 2011, David Howells wrote:

> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
> > compiling the kernel already with -mregparm=3. So the annotation of
> > the rwsem functions is redundant. Remove it.
> 
> That's fine - as long as we never remove the -mregparm=3 on i386.  The inline
> assembly relies on the regparm=3 calling convention.

If we remove that we'll break more than rwsems :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/