linux-kernel - Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110127182916.GA4688@amit-x200.redhat.com>
Date:	Thu, 27 Jan 2011 23:59:44 +0530
From:	Amit Shah <amit.shah@...hat.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/

On (Thu) Jan 20 2011 [10:03:43], Greg Kroah-Hartman wrote:
> As requested by Arnd Bergmann, the hvc drivers are now
> moved to the drivers/tty/hvc/ directory.  The virtio_console.c driver
> was also moved, as it required the hvc_console.h file to be able to be
> built, and it really is a hvc driver.

I just saw this now as a result of this patch entering mainline.  I
would have liked to be CC'ed to the patches.  Also, I don't like the
move of the virtio_console.c file to drivers/tty/hvc.  virtio_console.c
is not only an hvc driver; one of its functions is to hook some ports to
hvc, but it's mostly a generic driver these days.

(I also note the MAINTAINERS entry was ignored and not updated in the
3rd patch of this series.)

Can you please move it back?

I could perhaps think of a way of splitting the file so the hvc bits can
be moved to drivers/tty/hvc/ and having the core stay in drivers/char/,
but that'll have to wait for the next cycle.

		Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/