linux-kernel - Re: [alsa-devel] [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296160926.3376.56.camel@odin>
Date:	Thu, 27 Jan 2011 20:42:06 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	"Manjunathappa, Prakash" <prakash.pm@...com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	davinci-linux-open-source@...ux.davincidsp.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: DaVinci: fix kernel panic due to
 uninitialized platform_data

On Thu, 2011-01-27 at 19:17 +0530, Manjunathappa, Prakash wrote:
> This patch fixes the Kernel panic issue on accessing davinci_vc in
> cq93vc_probe function. struct davinci_vc is part of platform device's
> private driver data(codec->dev->p->driver_data) and this is populated
> by DaVinci Voice Codec MFD driver.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@...com>
> ---
> This patch applies to Linus's tree at [1].
> 
> [1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> ---
>  sound/soc/codecs/cq93vc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
> index 46dbfd0..347a567 100644
> --- a/sound/soc/codecs/cq93vc.c
> +++ b/sound/soc/codecs/cq93vc.c
> @@ -153,7 +153,7 @@ static int cq93vc_resume(struct snd_soc_codec *codec)
>  
>  static int cq93vc_probe(struct snd_soc_codec *codec)
>  {
> -	struct davinci_vc *davinci_vc = codec->dev->platform_data;
> +	struct davinci_vc *davinci_vc = snd_soc_codec_get_drvdata(codec);
>  
>  	davinci_vc->cq93vc.codec = codec;
>  	codec->control_data = davinci_vc;

Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/