linux-kernel - Re: [PATCH] qla2xxx: Fix possible race that could hang kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110127213255.GG31955@stratus.com>
Date:	Thu, 27 Jan 2011 16:32:55 -0500
From:	Bandan Das <bandan.das@...atus.com>
To:	James Bottomley <James.Bottomley@...e.de>
Cc:	andrew.vasquez@...gic.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qla2xxx: Fix possible race that could hang kthread_stop()


> That's not really the accepted way to fix these race conditions because
> of the double check of kthread_should_stop(); this is 
> James
> 
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index c194c23..15ce69e 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -3282,10 +3282,10 @@ qla2x00_do_dpc(void *data)
>  
>  	set_user_nice(current, -20);
>  
> +	set_current_state(TASK_INTERRUPTIBLE);
>  	while (!kthread_should_stop()) {
>  		DEBUG3(printk("qla2x00: DPC handler sleeping\n"));
>  
> -		set_current_state(TASK_INTERRUPTIBLE);
>  		schedule();
>  		__set_current_state(TASK_RUNNING);
>  
> @@ -3454,7 +3454,9 @@ qla2x00_do_dpc(void *data)
>  		qla2x00_do_dpc_all_vps(base_vha);
>  
>  		ha->dpc_active = 0;
> +		set_current_state(TASK_INTERRUPTIBLE);
>  	} /* End of while(1) */
> +	__set_current_state(TASK_RUNNING);
>  
>  	DEBUG(printk("scsi(%ld): DPC handler exiting\n", base_vha->host_no));
>  
Yes, this looks more clean and will take care of the problem I am hitting.


Bandan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/