linux-kernel - Re: [PATCH v2 18/28] ARM: tegra: add CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimZcg7Q-Tc=P7zf7=RQsyKJg_amWogP2Jafgxu0@mail.gmail.com>
Date:	Thu, 27 Jan 2011 14:07:01 -0800
From:	Colin Cross <ccross@...roid.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	linux-tegra@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	konkers@...roid.com, Gary King <gking@...dia.com>,
	linux-kernel@...r.kernel.org, olof@...om.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 18/28] ARM: tegra: add CPU_IDLE driver

On Thu, Jan 27, 2011 at 1:51 PM, Colin Cross <ccross@...roid.com> wrote:
> On Thu, Jan 27, 2011 at 12:38 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> On 01/23/2011 06:01 PM, Colin Cross wrote:
>>>
>>> +static int __init tegra_cpuidle_debug_init(void)
>>> +{
>>> +     struct dentry *dir;
>>> +     struct dentry *d;
>>> +
>>> +     dir = debugfs_create_dir("cpuidle", NULL);
>>> +     if (!dir)
>>> +             return -ENOMEM;
>>> +
>>> +     d = debugfs_create_file("lp2", S_IRUGO, dir, NULL,
>>> +             &tegra_lp2_debug_ops);
>>> +     if (!d)
>>> +             return -ENOMEM;
>>> +
>>> +     return 0;
>>> +}
>>> +#endif
>>> +
>>> +late_initcall(tegra_cpuidle_debug_init);
>>
>> Will this compile with CONFIG_DEBUG_FS=n?
>
> Yes.  All debugfs ops return ERR_PTR(-ENODEV) if CONFIG_DEBUG_FS=n, so
> tegra_cpuidle_debug_init will do nothing and return 0.
>

Oops no, it will not compile.  Will fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/