[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110126161648.39af9576.akpm@linux-foundation.org>
Date: Wed, 26 Jan 2011 16:16:48 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Daniel Lezcano <daniel.lezcano@...e.fr>
Cc: containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup : remove the ns_cgroup
On Tue, 25 Jan 2011 10:39:48 +0100
Daniel Lezcano <daniel.lezcano@...e.fr> wrote:
> The ns_cgroup is an annoying cgroup at the namespace / cgroup frontier
> and leads to some problems:
>
> * cgroup creation is out-of-control
> * cgroup name can conflict when pids are looping
> * it is not possible to have a single process handling
> a lot of namespaces without falling in a exponential creation time
> * we may want to create a namespace without creating a cgroup
>
> The ns_cgroup was replaced by a compatibility flag 'clone_children',
> where a newly created cgroup will copy the parent cgroup values.
> The userspace has to manually create a cgroup and add a task to
> the 'tasks' file.
>
> This patch removes the ns_cgroup as suggested in the following thread:
>
> https://lists.linux-foundation.org/pipermail/containers/2009-June/018616.html
>
> The 'cgroup_clone' function is removed because it is no longer used.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...e.fr>
> Signed-off-by: Serge E. Hallyn <serge.hallyn@...onical.com>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: Jamal Hadi Salim <hadi@...erus.ca>
> Reviewed-by: Li Zefan <lizf@...fujitsu.com>
> Acked-by: Paul Menage <menage@...gle.com>
> Acked-by: Matt Helsley <matthltc@...ibm.com>
>
> ...
>
> 22 files changed, 4 insertions(+), 287 deletions(-)
I didn't see that one coming.
This change is userspace-visible, is it not? What are the implications
of this? There's some discussion in that nearly-two-year-old thread
regarding making provision for back-compatibility but I'm not seeing
such things in this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists