linux-kernel - Re: [PATCH 2/7] PowerPC: add unlikely() to BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <m31v3xxrlz.fsf@redhat.com>
Date:	Fri, 28 Jan 2011 11:14:16 +0100
From:	Andreas Schwab <schwab@...hat.com>
To:	"David Laight" <David.Laight@...LAB.COM>
Cc:	"David Daney" <ddaney@...iumnetworks.com>,
	"Coly Li" <bosong.ly@...bao.com>,
	Wang Cong <xiyou.wangcong@...il.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Yong Zhang <yong.zhang0@...il.com>
Subject: Re: [PATCH 2/7] PowerPC: add unlikely() to BUG_ON()

"David Laight" <David.Laight@...LAB.COM> writes:

> Also, as (I think) in some of the generated code quoted,
> use of __builtin_expect() with a boolean expression can
> force some versions of gcc to generate the integer
> value of the expression

That's more likely a side effect of the definition of likely/unlikely:
they expand to !!(x).

Andreas.

-- 
Andreas Schwab, schwab@...hat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/