linux-kernel - Re: [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110128114214.GD20606@bicker>
Date:	Fri, 28 Jan 2011 14:42:15 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Vipin Mehta <vmehta@...eros.com>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and
 is_acl_data_frame to A_BOOL

On Thu, Jan 27, 2011 at 08:04:29PM -0800, Joe Perches wrote:
> -                A_UINT8 is_amsdu, tid, is_acl_data_frame;
> +                A_BOOL is_amsdu;
> +                A_UINT8 tid;
> +                A_BOOL is_acl_data_frame;

Just use bool for bool and u8 for u8.  It's not reasonable for everyone
to rename basic types for every driver.  (Unless Atheros bool really is
different from other people's bool then it would be totally reasonable).

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/