linux-kernel - Re: [PATCH -v2 1/3] Fix splitting poisoned THP.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110128161657.GG16981@random.random>
Date:	Fri, 28 Jan 2011 17:16:57 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	AKPM　 <akpm@...ux-foundation.org>,
	Huang Ying <ying.huang@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2 1/3] Fix splitting poisoned THP.

Hello Jin,

On Fri, Jan 28, 2011 at 02:52:48PM +0900, Jin Dongming wrote:
> +				/*
> +				 * FIXME: if splitting THP is failed, it is better
> +				 * to stop the following operation rather than
> +				 * causing panic by unmapping. System might survive
> +				 * if the page is freed later.
> +				 */

I don't think there would be panic by unmapping. But the page has
already been freed so there's no need to kill anything.

A part from this comment which I'm uncertain about the panic, this new
series looks good to me!

Thanks,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/