linux-kernel - RE: [PATCH v1] input: tegra-kbc: Fix build error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1FC56210173BB445BD77F608D6FB8D03165A0080A0@HQMAIL03.nvidia.com>
Date:	Fri, 28 Jan 2011 14:18:01 -0800
From:	Rakesh Iyer <riyer@...dia.com>
To:	'Dmitry Torokhov' <dmitry.torokhov@...il.com>
CC:	"olof@...om.net" <olof@...om.net>, Andrew Chew <AChew@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH v1] input: tegra-kbc: Fix build error.

No I think this slipped in, due to a last minute change to get the code < 80 lines.

Regards
Rakesh

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@...il.com]
> Sent: Friday, January 28, 2011 2:10 PM
> To: Rakesh Iyer
> Cc: olof@...om.net; Andrew Chew; linux-tegra@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-input@...r.kernel.org
> Subject: Re: [PATCH v1] input: tegra-kbc: Fix build error.
> 
> On Fri, Jan 28, 2011 at 02:03:33PM -0800, riyer@...dia.com wrote:
> > From: Rakesh Iyer <riyer@...dia.com>
> >
> > Fix build error introduced by variable name change.
> >
> 
> Did I manage to pick up wrong version?
> 
> > Signed-off-by: Rakesh Iyer <riyer@...dia.com>
> > ---
> >  drivers/input/keyboard/tegra-kbc.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> > index 6ca903a..ac471b7 100644
> > --- a/drivers/input/keyboard/tegra-kbc.c
> > +++ b/drivers/input/keyboard/tegra-kbc.c
> > @@ -355,8 +355,8 @@ static void tegra_kbc_config_pins(struct tegra_kbc *kbc)
> >  	for (i = 0; i < KBC_MAX_GPIO; i++) {
> >  		u32 r_shft = 5 * (i % 6);
> >  		u32 c_shft = 4 * (i % 8);
> > -		u32 r_mask = 0x1f << r_shift;
> > -		u32 c_mask = 0x0f << c_shift;
> > +		u32 r_mask = 0x1f << r_shft;
> > +		u32 c_mask = 0x0f << c_shft;
> >  		u32 r_offs = (i / 6) * 4 + KBC_ROW_CFG0_0;
> >  		u32 c_offs = (i / 8) * 4 + KBC_COL_CFG0_0;
> >  		u32 row_cfg = readl(kbc->mmio + r_offs);
> > --
> > 1.7.0.4
> >
> 
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/