linux-kernel - Re: [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32

Open Source and information security mailing list archives

Date:	Fri, 28 Jan 2011 09:22:11 +0300
From:	Denis Kirjanov <kirjanov@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Vipin Mehta <vmehta@...eros.com>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures
 with A_BOOL to u32

On Fri, Jan 28, 2011 at 7:04 AM, Joe Perches <joe@...ches.com> wrote:
> From: Joe Perches <joe@...eros-desktop.(none)>
>
> These structures are device native and need to be 4 bytes long.
>
> Signed-off-by: Joe Perches <joe@...eros-desktop.(none)>
> ---
You should fix your email address  here

>  drivers/staging/ath6kl/include/common/wmi.h |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/ath6kl/include/common/wmi.h b/drivers/staging/ath6kl/include/common/wmi.h
> index c75d310..eb8f7ba 100644
> --- a/drivers/staging/ath6kl/include/common/wmi.h
> +++ b/drivers/staging/ath6kl/include/common/wmi.h
> @@ -635,8 +635,8 @@ typedef enum {
>  } WMI_SCAN_TYPE;
>
>  typedef PREPACK struct {
> -    A_BOOL   forceFgScan;
> -    A_BOOL   isLegacy;        /* For Legacy Cisco AP compatibility */
> +    u32   forceFgScan;
> +    u32   isLegacy;        /* For Legacy Cisco AP compatibility */
>     A_UINT32 homeDwellTime;   /* Maximum duration in the home channel(milliseconds) */
>     A_UINT32 forceScanInterval;    /* Time interval between scans (milliseconds)*/
>     A_UINT8  scanType;           /* WMI_SCAN_TYPE */
> @@ -1241,7 +1241,7 @@ typedef PREPACK struct {
>  * WMI_ENABLE_RM_CMDID
>  */
>  typedef PREPACK struct {
> -        A_BOOL enable_radio_measurements;
> +        u32 enable_radio_measurements;
>  } POSTPACK WMI_ENABLE_RM_CMD;
>
>  /*
> @@ -2638,7 +2638,7 @@ typedef PREPACK struct {
>  } POSTPACK WMI_SET_KEEPALIVE_CMD;
>
>  typedef PREPACK struct {
> -    A_BOOL configured;
> +    u32 configured;
>     A_UINT8 keepaliveInterval;
>  } POSTPACK WMI_GET_KEEPALIVE_CMD;
>
> @@ -2717,8 +2717,8 @@ typedef PREPACK struct {
>  } POSTPACK WMI_SET_IP_CMD;
>
>  typedef PREPACK struct {
> -    A_BOOL awake;
> -    A_BOOL asleep;
> +    u32 awake;
> +    u32 asleep;
>  } POSTPACK WMI_SET_HOST_SLEEP_MODE_CMD;
>
>  typedef enum {
> @@ -2726,7 +2726,7 @@ typedef enum {
>  } WMI_WOW_FILTER;
>
>  typedef PREPACK struct {
> -    A_BOOL enable_wow;
> +    u32 enable_wow;
>     WMI_WOW_FILTER filter;
>     A_UINT16 hostReqDelay;
>  } POSTPACK WMI_SET_WOW_MODE_CMD;
> @@ -3010,7 +3010,7 @@ typedef PREPACK struct {
>  } POSTPACK WMI_AP_PROT_SCAN_TIME_CMD;
>
>  typedef PREPACK struct {
> -    A_BOOL flag;
> +    u32 flag;
>     A_UINT16 aid;
>  } POSTPACK WMI_AP_SET_PVB_CMD;
>
> --
> 1.7.4.rc3
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>


-- 
Regards,
Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives