lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Jan 2011 10:50:38 +0200 From: Pekka Enberg <penberg@...helsinki.fi> To: Robert Jennings <rcj@...ux.vnet.ibm.com> Cc: Nitin Gupta <ngupta@...are.org>, Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 7/7] zram/xvmalloc: combine duplicate block delete code On Fri, 2011-01-28 at 09:01 -0600, Robert Jennings wrote: > This patch eliminates duplicate code. The remove_block_head function > is a special case of remove_block which can be contained in remove_block > without confusion. > > The portion of code in remove_block_head which was noted as "DEBUG ONLY" > is now mandatory. Doing this provides consistent management of the double > linked list of blocks under a freelist and makes this consolidation > of delete block code safe. The first and last blocks will have NULL > pointers in their previous and next page pointers respectively. > > Additionally, any time a block is removed from a free list the next and > previous pointers will be set to NULL to avoid misuse outside xvmalloc. > > Signed-off-by: Robert Jennings <rcj@...ux.vnet.ibm.com> Looks OK to me but we should really get Nitin's ACK for this. Reviewed-by: Pekka Enberg <penberg@...nel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists