linux-kernel - [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101290132560.6465@swampdragon.chaosbits.net>
Date:	Sat, 29 Jan 2011 01:40:04 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	linux-kernel@...r.kernel.org
cc:	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Wu Fengguang <wfg@...ux.intel.com>
Subject: [PATCH] sound, hda_eld: suspicious sizeof() in call to
 snd_print_pcm_bits()

In hdmi_show_short_audio_desc() we call snd_print_pcm_bits() like this:
  snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
that last argument is supposed to be the size of the buffer that 
snd_print_pcm_bits() writes to, so I believe it should be this:
  snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);

Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 hda_eld.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Compile tested only. I don't have relevant hardware.

diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
index 4a66347..74b0560 100644
--- a/sound/pci/hda/hda_eld.c
+++ b/sound/pci/hda/hda_eld.c
@@ -381,7 +381,7 @@ static void hdmi_show_short_audio_desc(struct cea_sad *a)
 	snd_print_pcm_rates(a->rates, buf, sizeof(buf));
 
 	if (a->format == AUDIO_CODING_TYPE_LPCM)
-		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
+		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);
 	else if (a->max_bitrate)
 		snprintf(buf2, sizeof(buf2),
 				", max bitrate = %d", a->max_bitrate);


-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/