linux-kernel - Re: [PATCH RFC] serial-core: reset the console speed on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296346859.5397.29.camel@utx.lan>
Date:	Sun, 30 Jan 2011 01:20:58 +0100
From:	Stanislav Brabec <sbrabec@...e.cz>
To:	Yin Kangkai <kangkai.yin@...ux.intel.com>
Cc:	linux-serial <linux-serial@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Deepak Saxena <dsaxena@...top.org>,
	Jason Wang <jason77.wang@...il.com>,
	Daniel Drake <dsd@...top.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] serial-core: reset the console speed on resume

Yin Kangkai wrote on Tue 25 Jan 2011 at 18:43 +0800:

> On some platforms, we need to restore the console speed on resume even
> it was not suspended (no_console_suspend), and on others we don't have
> to do that.
> 
> So don't care about the "console_suspend_enabled" and unconditionally
> reset the console speed if it is a console.

Well, there is currently another breakage on Zaurus. But it improves the
situation.
(Note: Your patch has bad file path. I'll agree with such change after
this fix.)

Test report on Zaurus
(serial hardware itself is in undefined state after resume):

                                       before  after
login:                                   OK     OK
console:                               broken broken
console + login:                         OK     OK
console + no_console_suspend:          broken broken
login + no_console_suspend:              OK     OK
console + login + no_console_suspend:  broken   OK

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@...e.cz
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/