linux-kernel - Re: [PATCH] gpio: Make gpio_{request,free}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D45B6DC.9000603@metafoo.de>
Date:	Sun, 30 Jan 2011 20:07:08 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	David Brownell <david-b@...bell.net>,
	Eric Miao <eric.y.miao@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: Make gpio_{request,free}_array gpio array parameter
 const

On 01/30/2011 07:49 PM, Wolfram Sang wrote:
> On Sat, Jan 29, 2011 at 04:21:21PM +0100, Lars-Peter Clausen wrote:
>> gpio_{request,free}_array should not (and do not) modify the passed gpio array,
>> so make the parameter const.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> 
> Looks good to me. What about the users of these calls (luckily there don't seem
> to be many)?
> 
> Kind regards,
> 
>    Wolfram
> 

Hi

Well, they could, but don't have to, make their gpio array const now, if it is not
otherwise modified. But I guess that is something for a follow-up patch.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/