lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110130221434.GB28220@pengutronix.de>
Date:	Sun, 30 Jan 2011 23:14:34 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Joachim Eastwood <manabian@...il.com>
Cc:	rpurdie@...ys.net, riku.voipio@....fi,
	linux-kernel@...r.kernel.org, joachim.eastwood@...ron.com
Subject: Re: [leds-pca9532] Add gpio capability v2

On Sun, Jan 30, 2011 at 09:20:13PM +0100, Joachim Eastwood wrote:
> Hello,
> 
> This is v2 of the patch to add gpio capability to the leds-pca9532
> driver. Please read the first mail in this thread for more
> information.
> 
> Changes in v2:
> * Add Kconfig magic. gpio capability is now optional
> * Addressed review from Wolfram Sang
> 
> Wolfram: If this looks okey can I add your Reviewed-by tag?

The patch seems line-wrapped. Is checkpatch happy (enough), too?
Other than that looks good to me:

Reviewed-by: Wolfram Sang <w.sang@...gutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ