linux-kernel - Re: [PATCH v2 02/20] move get_jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1101311231270.31804@localhost6.localdomain6>
Date:	Mon, 31 Jan 2011 12:36:33 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Torben Hohn <torbenh@....de>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>, johnstul@...ibm.com,
	yong.zhang0@...il.com, hch@...radead.org
Subject: Re: [PATCH v2 02/20] move get_jiffies_64 to kernel/time/jiffies.c

On Thu, 27 Jan 2011, Torben Hohn wrote:

> in order to make the xtime_lock local to kernel/time
> all users of this lock need to be moved there.

Did you even compile that ?

kernel/time/jiffies.c:83: warning: data definition has no type or storage class
kernel/time/jiffies.c:83: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
kernel/time/jiffies.c:83: warning: parameter names (without types) in function declaration

That misses an #include <linux/module.h>

I fixed that up. Please be more careful next time.

Thanks,

	tglx