linux-kernel - Re: [RFC -v7 PATCH 5/7] export pid symbols needed for kvm_vcpu_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D46BCFD.9010300@redhat.com>
Date:	Mon, 31 Jan 2011 15:45:33 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Rik van Riel <riel@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Mike Galbraith <efault@....de>,
	Chris Wright <chrisw@...s-sol.org>, ttracy@...hat.com,
	"Nakajima, Jun" <jun.nakajima@...el.com>
Subject: Re: [RFC -v7 PATCH 5/7] export pid symbols needed for kvm_vcpu_on_spin

On 01/31/2011 03:43 PM, Peter Zijlstra wrote:
> On Mon, 2011-01-31 at 15:26 +0200, Avi Kivity wrote:
> >  On 01/31/2011 01:51 PM, Peter Zijlstra wrote:
> >  >  On Wed, 2011-01-26 at 17:23 -0500, Rik van Riel wrote:
> >  >  >   Export the symbols required for a race-free kvm_vcpu_on_spin.
> >  >
> >  >  Avi, you asked for an example of why I hated KVM as a module :-)
> >
> >  Why do you dislike exports so much?
>
> Because I hate modules [*],

Well, you could have just said you hate KVM as a module because it is a 
module, and saved one indirection.

> since we sadly cannot undo those, limiting
> the module interface is all we've got, and KVM is one that pushes the
> module interface further and further.
>
> Many people see an EXPORT as a acknowledgement that its OK to use the
> interface, even when its not.
>
> [*] they enable the binary junk thing.

Then we need to stop binary modules, not castrate modules as a whole.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/