linux-kernel - Re: [PATCH] Fix linux-next warning from abb74cef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110131113820.193a89c5.rdunlap@xenotime.net>
Date:	Mon, 31 Jan 2011 11:38:20 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Venkatesh Pallipadi <venki@...gle.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jaswinder Singh <jaswinderlinux@...il.com>
Subject: Re: [PATCH] Fix linux-next warning from abb74cef

On Mon, 31 Jan 2011 11:12:43 -0800 Venkatesh Pallipadi wrote:

> Yes. Patch below should fix the problem.
> 
> Fix below warning -
>  Introduced by commit abb74cefa9c682fb38ba86c17ca3c86fed6cc464 ("sched:
>  Export ns irqtimes through /proc/stat").
> 
> After merging the tip tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> kernel/sched.c:3719: warning: 'irqtime_account_idle_ticks' defined but not =
> used
> kernel/sched.c:3720: warning: 'irqtime_account_process_tick' defined but no=
> t used

[ugh on the '=' line continuations.]

> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Venkatesh Pallipadi <venki@...gle.com>
> ---
>  kernel/sched.c |   64 ++++++++++++++++++++++++++++----------------------------
>  1 files changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 477e1bc..9a552bd 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -3654,6 +3654,36 @@ void account_system_time(struct task_struct *p, int hardirq_offset,
>  	__account_system_time(p, cputime, cputime_scaled, target_cputime64);
>  }
>  
> +/*
> + * Account for involuntary wait time.
> + * @steal: the cpu time spent in involuntary wait

I see that you only moved this code, but please change @steal to @cputime also.

> + */
> +void account_steal_time(cputime_t cputime)
> +{
> +	struct cpu_usage_stat *cpustat = &kstat_this_cpu.cpustat;
> +	cputime64_t cputime64 = cputime_to_cputime64(cputime);
> +
> +	cpustat->steal = cputime64_add(cpustat->steal, cputime64);
> +}

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/