linux-kernel - Re: [PATCH -mmotm] backlight: apple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110131223103.GA15093@srcf.ucam.org>
Date:	Mon, 31 Jan 2011 22:31:03 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH -mmotm] backlight: apple_bl depends on ACPI

On Wed, Jan 26, 2011 at 11:16:02AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.
> 
> drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
> drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
> drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
> drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
> drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
> drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
> drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
> drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
> drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
> drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
> drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Matthew Garrett <mjg@...hat.com>
> Cc: Richard Purdie <rpurdie@...ys.net>

Acked-by: Matthew Garrett <mjg@...hat.com>

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/