linux-kernel - Re: b44 driver causes panic when using swiotlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110201225443U.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 1 Feb 2011 22:54:56 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	cebbert@...hat.com
Cc:	linux-kernel@...r.kernel.org, ak@...ux.intel.com,
	dwmw2@...radead.org, hancockrwd@...il.com,
	Larry.Finger@...inger.net
Subject: Re: b44 driver causes panic when using swiotlb

On Mon, 31 Jan 2011 10:54:12 -0500
Chuck Ebbert <cebbert@...hat.com> wrote:

> The b44 driver is triggering this panic in swiotlb_map_page():
> 
>         if (!dma_capable(dev, dev_addr, size))
>                 panic("map_single: bounce buffer is not DMA'ble");
> 
> The kernel log says the bounce buffers are at 0xdb400000, but b44 can
> only do DMA to the first 1GB of memory:

Can you try this? b44 has the own bouncing mechanism so if swiotlb
returns an error, the driver can allocate an appropriate buffer.

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index c47bbe1..93ca08b 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -686,8 +686,10 @@ dma_addr_t swiotlb_map_page(struct device *dev, struct page *page,
 	/*
 	 * Ensure that the address returned is DMA'ble
 	 */
-	if (!dma_capable(dev, dev_addr, size))
-		panic("map_single: bounce buffer is not DMA'ble");
+	if (!dma_capable(dev, dev_addr, size)) {
+		swiotlb_tbl_unmap_single(dev, map, size, dir);
+		dev_addr = swiotlb_virt_to_bus(dev, io_tlb_overflow_buffer);
+	}
 
 	return dev_addr;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/