linux-kernel - Re: [RFC Patch] virtio: export model and type in /sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110201174607.GA24924@redhat.com>
Date:	Tue, 1 Feb 2011 19:46:07 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Amerigo Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Anthony Liguori <aliguori@...ibm.com>,
	Jamie Lokier <jamie@...reable.org>,
	Thomas Weber <swirl@....li>,
	Ben Hutchings <ben@...adent.org.uk>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Andy Fleming <afleming@...escale.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC Patch] virtio: export model and type in /sys

On Tue, Feb 01, 2011 at 12:37:38PM -0500, Christoph Hellwig wrote:
> On Mon, Jan 31, 2011 at 10:53:00AM +0800, Amerigo Wang wrote:
> > Our kdump script needs /sys/block/X/device/{vendor, model, type},
> > but virtio devices don't have {model, type}, this patch adds them.
> > Actually, I don't know how to fill the model field, other block devices
> > seem read it from SCSI. Any comments?
> 
> It does not make any sense to fill this at all in virtio.  The
> attributes are simply exporting the SCSI INQUIRY data, and do not make
> any sense at all outside a SCSI context.
>  In fact the type field even
> contains numbers from the scsi protocol spec that just don't make sense.

ide seems to export these too.

$ cat /sys/class/block/sr0/device/model 
DVDRAM GSA-U20N 

and I am pretty sure my dvd isn't scsi ...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/