linux-kernel - Re: [leds-pca9532] Add gpio capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110201184414.GB16160@pengutronix.de>
Date:	Tue, 1 Feb 2011 19:44:14 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [leds-pca9532] Add gpio capability


> > +static int pca9532_gpio_direction_output(struct gpio_chip *gc,
> > unsigned offset, int val)
> > +{
> > + return 0;
> > +}
> > +
> 
> Not good.  When the pin is configured as an output, the direction_output method also
> requests that the pin be set to a desired level.  For this driver that means that the
> pca9532_gpio_direction_output function just needs to call pca9532_gpio_set_value.

Ack, missed that. Thanks a lot!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)