linux-kernel - Change DECOMPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AANLkTikFBZT6+8_MAJ6xd+uPrwJnomPbhX9toNuncm0N@mail.gmail.com>
Date:	Wed, 2 Feb 2011 00:25:46 +0100
From:	Marcel Korpel <marcel.lists@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Subject: Change DECOMPRESS_LZMA to boolean

On Sun, 03 Jan 2010 00:55:55 +0000 Phillip Lougher wrote:
> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> >
> > When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma
> > is built but then discarded from the library because no built-in code
> > uses it, so change it from a lib- to an obj- to force it to be kept
> > in the library.
> >
> > ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined!
> >
>
> Thanks for fixing this, I should have spotted it in my various
> config tests but didn't.  I could add this to my squashfs-next patches
> to stop the linux-next tree breakage, however, should it go into
> Michal's kbuild -next tree instead?
>
> This patch raises a small additional issue, why is DECOMPRESS_LZMA
> (and DECOMPRESS_GZIP/DECOMPRESS_BZIP2) and defined as tristate?
> None of the above compressors can be built as modules.

I just ran into this exact same issue, when disabling DEV_BLK_INITRD
and setting SQUASHFS to "m" and selecting SQUASHFS_LZMA. The option
then evaluates to:

  DECOMPRESS_LZMA [=m]
  Selected by: RD_LZMA [=n] && BLK_DEV_INITRD [=n] ||
  SQUASHFS_LZMA [=y] && MISC_FILESYSTEMS [=y] && SQUASHFS [=m]

With these settings the linker complains:

  Error: "unlzma" [fs/squashfs/squashfs.ko] undefined

Please change DECOMPRESS_LZMA (and perhaps the other DECOMPRESS_*
symbols) to boolean.

Regards,
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/