lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Feb 2011 16:45:26 -0800 (PST) From: Andi Kleen <andi@...stfloor.org> To: tj@...nel.org, ak@...ux.intel.com, jgarzik@...hat.com, gregkh@...e.de, linux-kernel@...r.kernel.org, stable@...nel.org Subject: [PATCH] [127/139] libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr() 2.6.35-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Tejun Heo <tj@...nel.org> commit 687a993339c4f3a63654746230da3aab8bbdbffd upstream. While separating out BMDMA irq handler from SFF, commit c3b28894 (libata-sff: separate out BMDMA irq handler) incorrectly made __ata_sff_port_intr() consider an IRQ to be an idle one if the host state was transitioned to HSM_ST_ERR by ata_bmdma_port_intr(). This makes BMDMA drivers ignore IRQs reporting host bus error which leads to timeouts instead of triggering EH immediately. Fix it by making __ata_sff_port_intr() consider the IRQ to be an idle one iff the state is HSM_ST_IDLE. This is equivalent to adding HSM_ST_ERR to the "break"ing case but less error-prone. Signed-off-by: Tejun Heo <tj@...nel.org> Signed-off-by: Andi Kleen <ak@...ux.intel.com> Reported-by: Antonio Toma <antonio.toma@...il.com> Signed-off-by: Jeff Garzik <jgarzik@...hat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> --- drivers/ata/libata-sff.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) Index: linux-2.6.35.y/drivers/ata/libata-sff.c =================================================================== --- linux-2.6.35.y.orig/drivers/ata/libata-sff.c +++ linux-2.6.35.y/drivers/ata/libata-sff.c @@ -1515,11 +1515,10 @@ static unsigned int __ata_sff_port_intr( if (!(qc->dev->flags & ATA_DFLAG_CDB_INTR)) return ata_sff_idle_irq(ap); break; - case HSM_ST: - case HSM_ST_LAST: - break; - default: + case HSM_ST_IDLE: return ata_sff_idle_irq(ap); + default: + break; } /* check main status, clearing INTRQ if needed */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists