[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110202235948.GA8676@dtor-ws.eng.vmware.com>
Date: Wed, 2 Feb 2011 15:59:49 -0800
From: Dmitry Torokhov <dtor@...are.com>
To: Andreas Schwab <schwab@...ux-m68k.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
Rusty Russell <rusty@...tcorp.com.au>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Linux/m68k <linux-m68k@...r.kernel.org>,
Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: Early crash (was: Re: module: show version information for
built-in modules in sysfs)
On Wed, Feb 02, 2011 at 02:52:04PM -0800, Andreas Schwab wrote:
> Dmitry Torokhov <dtor@...are.com> writes:
>
> > But why is it aligned on 2-byte boundary and why m64k is not happy with
> > module_version_attribute but is happy with kernel_param which is also
> > aligned similarly?
>
> struct kernel_parm doesn't contain internal padding on 32 bit
> architectures (it does on 64bit architectures though).
>
> > If we unroll module_version_attribute it woud look like this:
> >
> > struct module_version_attribute {
> >
> > struct module_attribute {
> >
> > struct attribute {
> > const char *name;
> > mode_t mode;
> > } attr;
> > ...
> >
> > } mattr;
> >
> > const char *module_name;
> > const char *version;
> > };
> >
> > So I would expect it be aligned on (char *) boundary which should be the
> > same as (void *).
>
> mode_t is a 16 bit type, thus any following member becomes aligned on an
> odd 2 byte boundary.
Even pointers? I'd expect pointers to be aligned on 4-bytes boundaries?
Thanks,
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists