linux-kernel - Re: [PATCH] Fix EDD3.0 data verification.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Feb 2011 12:04:03 +0200
From:	Gleb Natapov <gleb@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH] Fix EDD3.0 data verification.

On Wed, Feb 02, 2011 at 11:56:55AM -0800, H. Peter Anvin wrote:
> On 02/02/2011 09:59 AM, Gleb Natapov wrote:
> > 
> > Ah I see what length you were referring to params->device_path_info_length.
> > If we will use that then we will get correct checksum for BIOSes that work
> > according to phoenix spec too, but edd_show_interface() and edd_show_host_bus()
> > handle only T13 spec so the information they show can be incorrect. I can
> > change code to check that params->device_path_info_length == 44 in addition
> > to checking csum. What do you think?
> > 
> 
> Yes, you need to check both.
OK.

> 
> This is really a union of two similar-but-not-identical structures
> distinguished by the length field.
> 
Yes, unfortunately phoenix spec lacks some vital information that is
needed to find the device edd entry corresponds too. SCSI target or IDE
channel for instance.
 
--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/