linux-kernel - Re: [PATCH 5/8] HID: roccat: Added ioctl command to retreive report size from chardev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1102031116100.2160@pobox.suse.cz>
Date:	Thu, 3 Feb 2011 11:17:24 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Weber <weber@...science.de>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 5/8] HID: roccat: Added ioctl command to retreive report
 size from chardev

On Sun, 30 Jan 2011, Stefan Achatz wrote:

> diff --git a/include/linux/roccat.h b/include/linux/roccat.h
> new file mode 100644
> index 0000000..24e1ca0
> --- /dev/null
> +++ b/include/linux/roccat.h
> @@ -0,0 +1,29 @@
> +#ifndef __HID_ROCCAT_H
> +#define __HID_ROCCAT_H
> +
> +/*
> + * Copyright (c) 2010 Stefan Achatz <erazor_de@...rs.sourceforge.net>
> + */
> +
> +/*
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the Free
> + * Software Foundation; either version 2 of the License, or (at your option)
> + * any later version.
> + */
> +
> +#include <linux/hid.h>
> +#include <linux/types.h>
> +
> +#define ROCCATIOCGREPSIZE _IOR('H', 0xf1, int)
> +
> +#ifdef __KERNEL__
> +
> +int roccat_connect(struct class *klass, struct hid_device *hid,
> +		int report_size);
> +void roccat_disconnect(int minor);
> +int roccat_report_event(int minor, u8 const *data);
> +
> +#endif
> +
> +#endif

I think something like include/linux/hid-roccat.h would be better here.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/