linux-kernel - Re: rename_rev.pl script for reviewing renames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110203102219.GB6508@pengutronix.de>
Date:	Thu, 3 Feb 2011 11:22:19 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Dan Carpenter <error27@...il.com>, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: rename_rev.pl script for reviewing renames

On Thu, Feb 03, 2011 at 01:08:28PM +0300, Dan Carpenter wrote:
> There are a lot of refactoring patches where people change camel case
> names to kernel style names etc.  I've written a script to make it
> easier to review them.  It's attached.

Cool, thanks for sharing. I guess my comments won't matter much, here
they are anyway :)

> sub usage() {
>     print "cat diff | transform.pl old new old new old new...\n";

Filename of the tool does not match.

>     # white space at the end of lines
>     $line =~ s/ *$//g;
>     $line =~ s/\t*$//g;

Character class here as well? Will also get mixtures of the two.

> while (<>) {
>     my $line = $_;

You could work here with plain $_, but I assume you don't do on purpose.

> 
>     if ($line =~ /^---/) {
> 	next;
>     }
>     if ($line =~ /^\+\+\+/) {
> 	next;
>     }

Use an alternation in the regexp?

>     my $output = filter($line);
>     if ($line =~ /^-/) {
> 	print $oldfh $output;
> 	next;
>     }
>     if ($line =~ /^\+/) {
> 	print $newfh $output;
> 	next;
>     }

Ditto.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)