linux-kernel - Re: [PATCH] [128/139] mac80211: fix mesh forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110203000630.GJ15569@one.firstfloor.org>
Date:	Thu, 3 Feb 2011 01:06:30 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Johannes Berg <johannes.berg@...el.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"javier@...ybit.com" <javier@...ybit.com>,
	"linville@...driver.com" <linville@...driver.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: Re: [PATCH] [128/139] mac80211: fix mesh forwarding

On Wed, Feb 02, 2011 at 08:56:14AM +0100, Johannes Berg wrote:
> On Wed, 2011-02-02 at 00:45 +0000, Andi Kleen wrote:
> 
> > -			if (!fwd_skb && net_ratelimit())
> > +			if (!fwd_skb && net_ratelimit()) {
> >  				printk(KERN_DEBUG "%s: failed to clone mesh frame\n",
> >  						   sdata->name);
> > +				goto out;
> > +			}
> 
> The net_ratelimit() here cause an obvious bug that I missed and a patch
> for that was submitted later -- you may want to pick that one up and/or
> fold it in (commit 919bbad580445801c22ef6ccbe624551fee652bd).

Added thanks.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/