linux-kernel - Re: [PATCH TIP 03/14] x86/dtb: Add a device tree for CE4100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110203205928.GH6180@angua.secretlab.ca>
Date:	Thu, 3 Feb 2011 13:59:28 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	David Gibson <david@...son.dropbear.id.au>,
	linux-kernel@...r.kernel.org, sodaville@...utronix.de,
	devicetree-discuss@...ts.ozlabs.org, x86@...nel.org
Subject: Re: [PATCH TIP 03/14] x86/dtb: Add a device tree for CE4100

On Thu, Jan 27, 2011 at 02:41:47PM +0530, Sebastian Andrzej Siewior wrote:
> * David Gibson | 2011-01-27 15:00:27 [+1000]:
> >> +					>;
> >> +
> >> +				i2c-controller@...00,0,0 {
> >
> >Uh.. that unit address does not look right.  The encoding of PCI
> >3-cell addresses into a unit address string is not simply comma
> >separated cells.  I forget the details, so you'll need to check the OF
> >PCI binding.
> 
> Grant wrote [0]:
> |You'll also note that I added ',0,0' to the end of the address.
> |That's because the node address reflects the parent bus address format
> |which uses 3 cells in this case.

It is quite possible I was mistaken on this point.  The PCI binding is
not my area of strength.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/