linux-kernel - Re: [patch rfc] memcg: remove NULL check from lookup_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Feb 2011 08:59:13 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch rfc] memcg: remove NULL check from lookup_page_cgroup()
 result

On Thu, 3 Feb 2011 15:12:30 +0100
Johannes Weiner <hannes@...xchg.org> wrote:

> The page_cgroup array is set up before even fork is initialized.  I
> seriously doubt that this code executes before the array is alloc'd.
> 
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>

I don't have solid answer to this. If some module use radix-tree and enter pages
to it, mem_cgroup may see it. But..

For my opinion, tring this is good.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

> ---
>  mm/memcontrol.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index a145c9e..6abaa10 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2343,10 +2343,7 @@ static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm,
>  	}
>  
>  	pc = lookup_page_cgroup(page);
> -	/* can happen at boot */
> -	if (unlikely(!pc))
> -		return 0;
> -	prefetchw(pc);
> +	BUG_ON(!pc); /* XXX: remove this and move pc lookup into commit */
>  
>  	ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, oom, page_size);
>  	if (ret || !mem)
> -- 
> 1.7.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/