linux-kernel - Re: [PATCH] sysctl: fix binary sysctl overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m11v3nik19.fsf@fess.ebiederm.org>
Date:	Fri, 04 Feb 2011 13:09:38 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Lucian Adrian Grijincu <lucian.grijincu@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl: fix binary sysctl overflow

Lucian Adrian Grijincu <lucian.grijincu@...il.com> writes:

> We allocated a vector of CTL_MAXNAME elements and considered
> [0, CTL_MAXNAME] as valid indexes in the vector.
>
> This fixes valid index range to be [0, CTL_MAXNAME).
>
> I guess this should be backported to stable trees too.

No.  This part of the code is correct.  0 is a valid index,
and the array is only CTL_MAXNAME entries long.

I think the maximum depth of this table is only about 6, but
feel free to count and tell me CTL_MAXNAME is set too low.

Eric

>
> Signed-off-by: Lucian Adrian Grijincu <lucian.grijincu@...il.com>
> ---
>  kernel/sysctl_binary.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
> index b875bed..e2f377c 100644
> --- a/kernel/sysctl_binary.c
> +++ b/kernel/sysctl_binary.c
> @@ -1446,7 +1446,7 @@ static ssize_t do_sysctl(int __user *args_name, int nlen,
>  	int i;
>  
>  	/* Check args->nlen. */
> -	if (nlen < 0 || nlen > CTL_MAXNAME)
> +	if (nlen < 0 || nlen >= CTL_MAXNAME)
>  		return -ENOTDIR;
>  	/* Read in the sysctl name for simplicity */
>  	for (i = 0; i < nlen; i++)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/