linux-kernel - Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110204220007.GA6052@elte.hu>
Date:	Fri, 4 Feb 2011 23:00:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	John Villalovos <jvillalo@...hat.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"John L. Villalovos" <john.l.villalovos@...el.com>,
	prarit@...hat.com
Subject: Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique


* H. Peter Anvin <hpa@...or.com> wrote:

> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> > 
> > There are five identical "broken BIOS!!" messages.  This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> > 
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
> 
> How about labelling these "MPBIOS" or so, too?

Yeah.

Also, the messages do not need to shout i suspect - the '!!' can be removed as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/