linux-kernel - Re: [USB]Add quirk for Samsung Android phone modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1102051514150.4210-100000@netrider.rowland.org>
Date:	Sat, 5 Feb 2011 15:15:27 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Maciej Szmigiero <mhej@...pl>
cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Oliver Neukum <oneukum@...e.de>,
	Hans de Goede <hdegoede@...hat.com>,
	Paul Mortier <mortier@...nternet.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [USB]Add quirk for Samsung Android phone modem

On Sat, 5 Feb 2011, Maciej Szmigiero wrote:

> [USB]Add quirk for Samsung Android phone modem
> 
> My Galaxy Spica needs this quirk when in modem mode, otherwise
> it causes endless USB bus resets and is unusable in this mode.
> 
> Unfortunately Samsung decided to reuse ID of its old CDMA phone SGH-I500
> for the modem part.
> That's why in addition to this patch the visior driver must be prevented
> from binding to SPH-I500 ID, so ACM driver can do that.
> 
> Signed-off-by: Maciej Szmigiero <mhej@...pl>
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 44c5954..363355b 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -88,6 +88,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>      /* INTEL VALUE SSD */
>      { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>  
> +    /* Samsung Android phone modem - ID conflict with SPH-I500 */
> +    { USB_DEVICE(0x04e8, 0x6601), .driver_info =
> +            USB_QUIRK_CONFIG_INTF_STRINGS },
> +
>      { }  /* terminating entry must be last */
>  };

Please follow the directions at the start of the source file: Keep the 
list ordered by vendor ID, then product ID.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/