linux-kernel - Re: [PATCH v6] spi: New driver for Altera SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D4D4BD6.3040909@wytron.com.tw>
Date:	Sat, 05 Feb 2011 21:08:38 +0800
From:	Thomas Chou <thomas@...ron.com.tw>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org, nios2-dev@...c.et.ntust.edu.tw,
	devicetree-discuss@...ts.ozlabs.org,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v6] spi: New driver for Altera SPI

On 02/04/2011 01:34 AM, Grant Likely wrote:
> Hi Thomas, comments below, but looking pretty close.

Thanks a lot.

>> +config SPI_ALTERA
>> +	tristate "Altera SPI Controller"
>> +	select SPI_BITBANG
>
> Will this compile on all architectures?  Will it break allyesconfig
> on anything other than nios?

Yes, it compile on other architectures. I will add 'default n' though.

There are soft-core arm, mips and coldfire running on altera fpga. 
Others might use fpga as peripheral extender, too. So we shouldn't limit 
it to nios2.

>> +static int __init altera_spi_init(void)
>> +{
>> +	return platform_driver_probe(&altera_spidrv, altera_spi_probe);
>
> platform_driver_register() please, and put the altera_spi_probe()
> routine into the driver structure.

I will change it to register as you suggested.

- Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/