linux-kernel - Re: [V9fs-developer] [RFC PATCH -V2 01/17] fs/9p: set the cached file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Feb 2011 09:02:11 -0600
From:	Eric Van Hensbergen <ericvh@...il.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	v9fs-developer@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [V9fs-developer] [RFC PATCH -V2 01/17] fs/9p: set the cached
 file_operations struct during inode init

On Sat, Feb 5, 2011 at 11:46 AM, Aneesh Kumar K.V
<aneesh.kumar@...ux.vnet.ibm.com> wrote:

>  /**
>  * v9fs_file_open - open a file (or directory)
>  * @inode: inode to be opened
> @@ -89,19 +86,12 @@ int v9fs_file_open(struct inode *inode, struct file *file)
>        }
>
>        file->private_data = fid;
> +#ifdef CONFIG_9P_FSCACHE
>        if ((fid->qid.version) && (v9ses->cache)) {
>                P9_DPRINTK(P9_DEBUG_VFS, "cached");
> -               /* enable cached file options */
> -               if(file->f_op == &v9fs_file_operations)
> -                       file->f_op = &v9fs_cached_file_operations;
> -               else if (file->f_op == &v9fs_file_operations_dotl)
> -                       file->f_op = &v9fs_cached_file_operations_dotl;
> -
> -#ifdef CONFIG_9P_FSCACHE
>                v9fs_cache_inode_set_cookie(inode, file);
> -#endif
>        }
> -
> +#endif
>        return 0;
>  }

Doesn't this conditionalize all cached operations on FSCACHE operation?
What if we want loose cache policy without FSCACHE?

     -eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/