| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110207170213.GP10564@opensource.wolfsonmicro.com> Date: Mon, 7 Feb 2011 17:02:14 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Lars-Peter Clausen <lars@...afoo.de> Cc: Liam Girdwood <lrg@...mlogic.co.uk>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration Please fix your MUA to word wrap at less than 80 columns, I've reflowed your text so it's legible. On Mon, Feb 07, 2011 at 05:53:56PM +0100, Lars-Peter Clausen wrote: > > In any > > case, we clearly shouldn't be applying patches which bodge around the > > core. > Well the alternative would be a patch looking like this: > - .cpu_dai_name = "bluetooth-dai", > + .cpu_dai_name = "soc-core", > Which isn't really nice either. If you think the core isn't behaving helpfully the core should be changed. This is part of how APIs evolve to be maximally useful. To be honest it's not massively obvious that we shouldn't just be taking the name of the device here, either using a device to represent the modem or registering the card using snd_soc_register_machine() and using a more meaningful name for the card seems like a sensible approach here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists