linux-kernel - [PATCH] x86, pci: early dump skip device the same way as later probe code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4D506BC8.8080705@kernel.org>
Date:	Mon, 07 Feb 2011 14:01:44 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	linux-kernel@...r.kernel.org,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: [PATCH] x86, pci: early dump skip device the same way as later probe
 code


Use VENDOR_ID instead of CLASS_REVISION.

Do have one system with 0x00ffffff CLASS_REVSION

Signed-off-by: Yinghai Lu <yinghai@...nel.org>

---
 arch/x86/pci/early.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Index: linux-2.6/arch/x86/pci/early.c
===================================================================
--- linux-2.6.orig/arch/x86/pci/early.c
+++ linux-2.6/arch/x86/pci/early.c
@@ -88,12 +88,17 @@ void early_dump_pci_devices(void)
 	for (bus = 0; bus < 256; bus++) {
 		for (slot = 0; slot < 32; slot++) {
 			for (func = 0; func < 8; func++) {
-				u32 class;
+				u32 l;
 				u8 type;
 
-				class = read_pci_config(bus, slot, func,
-							PCI_CLASS_REVISION);
-				if (class == 0xffffffff)
+				l = read_pci_config(bus, slot, func,
+							PCI_VENDOR_ID);
+				/*
+				 * some broken boards return 0 or ~0 if a slot
+				 *  is empty
+				 */
+				if (l == 0xffffffff || l == 0x00000000 ||
+				    l == 0x0000ffff || l == 0xffff0000)
 					continue;
 
 				early_dump_pci_device(bus, slot, func);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/