[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <AANLkTinMBQZa+-_T4O1dOZcUGjOM4748J+m_WmEV=LXW@mail.gmail.com>
Date: Mon, 7 Feb 2011 11:03:15 +0530
From: "Menon, Nishanth" <nm@...com>
To: Kevin Hilman <khilman@...com>
Cc: Vasiliy Kulikov <segoon@...nwall.com>,
linux-kernel@...r.kernel.org, security@...nel.org,
Tony Lindgren <tony@...mide.com>,
Russell King <linux@....linux.org.uk>,
linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs
voltage files
On Sat, Feb 5, 2011 at 04:24, Kevin Hilman <khilman@...com> wrote:
> Vasiliy Kulikov <segoon@...nwall.com> writes:
>
>> Don't allow everybody to change voltage settings.
>>
>> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
>> ---
>> Cannot compile the driver, so it is not tested at all.
>
> Acked-by: Kevin Hilman <khilman@...com>
Also fixes the checkpatch warning:
scripts/checkpatch.pl -f arch/arm/mach-omap2/smartreflex.c
WARNING: Exporting world writable files is usually an error. Consider
more restrictive permissions.
#903: FILE: arm/mach-omap2/smartreflex.c:903:
+ (void) debugfs_create_file("autocomp", S_IRUGO | S_IWUGO, dbg_dir,
total: 0 errors, 1 warnings, 1028 lines checked
Acked-by: Nishanth Menon <nm@...com>
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists