linux-kernel - Re: [PATCH 3/4] olpc_dcon: move more variables into dcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Feb 2011 09:30:47 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	jon.nettleton@...il.com, cjb@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] olpc_dcon: move more variables into dcon_priv

On Sun, Feb 06, 2011 at 03:28:46PM -0800, Andres Salomon wrote:
>  	bool mono:1;
> +	bool asleep:1;
                   ^^ 

Not needed.

> -	return sprintf(buf, "%d\n", dcon_sleep_val);
> +	struct dcon_priv *dcon = dev_get_drvdata(dev);
> +	return sprintf(buf, "%d\n", dcon->asleep ? 1 : 0);
                                                 ^^^^^^^

Also not needed.

These are fussy things.  Feel free to fix them in a later patch series.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/