linux-kernel - Re: [PATCH 02/14] POWER: bq27x00: Improve temperature precession

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110207080629.GB6177@enneenne.com>
Date:	Mon, 7 Feb 2011 09:06:29 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Grazvydas Ignotas <notasas@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/14] POWER: bq27x00: Improve temperature precession

On Sun, Feb 06, 2011 at 01:47:59AM +0100, Lars-Peter Clausen wrote:
> This patch improves the precession of the temperature property of the bq27x00
> driver.
> By dividing before multiplying the current code effectively cuts of the last
> decimal digit. This patch fixes it by multiplying before dividing.
> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> ---
>  drivers/power/bq27x00_battery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index bb043f9..4f74659 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -109,7 +109,7 @@ static int bq27x00_battery_temperature(struct bq27x00_device_info *di)
>  	if (di->chip == BQ27500)
>  		return temp - 2731;
>  	else
> -		return ((temp >> 2) - 273) * 10;
> +		return ((temp * 5) - 5463) / 2;
>  }
>  
>  /*
> -- 
> 1.7.2.3

Acked-by: Rodolfo Giometti <giometti@...ux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/